]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
rds: Integer overflow in RDS cmsg handling
authorDan Rosenberg <drosenberg@vsecurity.com>
Wed, 17 Nov 2010 06:37:16 +0000 (06:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Nov 2010 20:20:52 +0000 (12:20 -0800)
commit218854af84038d828a32f061858b1902ed2beec6
treed5c688bc9856b3763e354619ff46ebe20edad891
parent7d98ffd8c2d1da6cec5d84eba42c4aa836a93f85
rds: Integer overflow in RDS cmsg handling

In rds_cmsg_rdma_args(), the user-provided args->nr_local value is
restricted to less than UINT_MAX.  This seems to need a tighter upper
bound, since the calculation of total iov_size can overflow, resulting
in a small sock_kmalloc() allocation.  This would probably just result
in walking off the heap and crashing when calling rds_rdma_pages() with
a high count value.  If it somehow doesn't crash here, then memory
corruption could occur soon after.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/rdma.c