]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
cifs: fix locking and list handling code in cifs_open and its helper
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 13:53:37 +0000 (09:53 -0400)
committerSteve French <sfrench@us.ibm.com>
Fri, 25 Sep 2009 17:59:31 +0000 (17:59 +0000)
commit3321b791b2e8897323f8c044a0c77ff25781381c
treecf349723b7b4f48151d10eeaeff322c05fd9de3b
parent15dd478107fb110689ef09d276d84051b31b7e5c
cifs: fix locking and list handling code in cifs_open and its helper

The patch to remove cifs_init_private introduced a locking imbalance. It
didn't remove the leftover list addition code and the unlocking in that
function. cifs_new_fileinfo does the list addition now, so there should
be no need to do it outside of that function.

pCifsInode will never be NULL, so we don't need to check for that. This
patch also gets rid of the ugly locking and unlocking across function
calls.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/file.c