]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
ceph: fix ceph_lookup_open intent usage
authorSage Weil <sage@newdream.net>
Tue, 26 Jul 2011 18:28:11 +0000 (11:28 -0700)
committerSage Weil <sage@newdream.net>
Tue, 26 Jul 2011 18:28:11 +0000 (11:28 -0700)
commit468640e32c7f6bfdaaa011095cc388786755d159
treebeb059d860c2ca39cda9ca3aa45603025655e1a6
parent9bae113a085b790de384bf86f09e15b42a65a985
ceph: fix ceph_lookup_open intent usage

We weren't properly calling lookup_instantiate_filp when setting up the
lookup intent, which could lead to file leakage on errors.  So:

 - use separate helper for the hidden snapdir translation, immediately
   following the mds request
 - use ceph_finish_lookup for the final dentry/return value dance in the
   exit path
 - lookup_instantiate_filp on success

Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Reviewed-by: Yehuda Sadeh <yehuda@hq.newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
fs/ceph/dir.c
fs/ceph/file.c
fs/ceph/super.h