]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
net: packet: fix information leak to userland
authorVasiliy Kulikov <segooon@gmail.com>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
commit67286640f638f5ad41a946b9a3dc75327950248f
tree34844d5e00a54f78b384f75f6cded995423d7fc6
parent57fe93b374a6b8711995c2d466c502af9f3a08bb
net: packet: fix information leak to userland

packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c