]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
checkpatch: suggest using min_t or max_t
authorJoe Perches <joe@perches.com>
Tue, 26 Jul 2011 00:13:22 +0000 (17:13 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 26 Jul 2011 03:57:16 +0000 (20:57 -0700)
commit7d2367af0b09f8028dc5c1b1919bb82d141c2afb
treee2645027cae1b716443e2659bda5364cb101d4e0
parent27c46a2546c75c6814562e85b751e3d64c188ad5
checkpatch: suggest using min_t or max_t

A common issue with min() or max() is using a cast on one or both of the
arguments when using min_t/max_t could be better.

Add cast detection to uses of min/max and suggest an appropriate use of
min_t or max_t instead.

Caveat:  This only works for min() or max() on a single line.
         It does not find min() or max() split across multiple lines.

This does find:
min((u32)foo, bar);
But it does not find:
max((unsigned long)foo,
    bar);

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl