drivers/video/exynos/exynos_mipi_dsi.c: fix an error check condition
authorSachin Kamat <sachin.kamat@linaro.org>
Fri, 22 Feb 2013 00:42:27 +0000 (16:42 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 22 Feb 2013 01:22:18 +0000 (17:22 -0800)
Checking an unsigned variable for negative value returns false.  Hence use
the macro to fix it.

Fixes the following smatch warning:

  drivers/video/exynos/exynos_mipi_dsi.c:417 exynos_mipi_dsi_probe() warn: unsigned 'dsim->irq' is never less than zero.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Donghwa Lee <dh09.lee@samsung.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/exynos/exynos_mipi_dsi.c

index 4a17cdccef3466f616178688436b39a856ded206..f623dfcca9275d5575ef34d7b4e2a288a45fdfcb 100644 (file)
@@ -414,7 +414,7 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
        }
 
        dsim->irq = platform_get_irq(pdev, 0);
        }
 
        dsim->irq = platform_get_irq(pdev, 0);
-       if (dsim->irq < 0) {
+       if (IS_ERR_VALUE(dsim->irq)) {
                dev_err(&pdev->dev, "failed to request dsim irq resource\n");
                ret = -EINVAL;
                goto err_platform_get_irq;
                dev_err(&pdev->dev, "failed to request dsim irq resource\n");
                ret = -EINVAL;
                goto err_platform_get_irq;