proc-ns: use d_set_d_op() API to set dentry ops in proc_ns_instantiate().
authorPravin B Shelar <>
Fri, 23 Mar 2012 22:02:55 +0000 (15:02 -0700)
committerLinus Torvalds <>
Fri, 23 Mar 2012 23:58:42 +0000 (16:58 -0700)
The namespace cleanup path leaks a dentry which holds a reference count
on a network namespace.  Keeping that network namespace from being freed
when the last user goes away.  Leaving things like vlan devices in the
leaked network namespace.

If you use ip netns add for much real work this problem becomes apparent
pretty quickly.  It light testing the problem hides because frequently
you simply don't notice the leak.

Use d_set_d_op() so that DCACHE_OP_* flags are set correctly.

This issue exists back to 3.0.

Acked-by: "Eric W. Biederman" <>
Reported-by: Justin Pettit <>
Signed-off-by: Pravin B Shelar <>
Signed-off-by: Jesse Gross <>
Cc: David Miller <>
Cc: <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>

index 27da860115c64aac30f8bd591adb1230f2bdeba6..3551f1f839eb163801a22bfb1243211ee41b404f 100644 (file)
@@ -53,7 +53,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir,
        ei->ns_ops    = ns_ops;
        ei->ns        = ns;
-       dentry->d_op = &pid_dentry_operations;
+       d_set_d_op(dentry, &pid_dentry_operations);
        d_add(dentry, inode);
        /* Close the race of the process dying before we return the dentry */
        if (pid_revalidate(dentry, NULL))