]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
drivers/video/backlight/lms283gf05.c: use GPIOF_INIT flags when using devm_gpio_reque...
authorJingoo Han <jg1.han@samsung.com>
Tue, 18 Dec 2012 00:01:12 +0000 (16:01 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 18 Dec 2012 01:15:17 +0000 (17:15 -0800)
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:

   GPIOF_DIR_OUT   (0 << 0)
   GPIOF_DIR_IN    (1 << 0)

So, when !pdata->reset_inverted is 1, the gpio pin can be set as
input, instead of output.

To prevent this problem, GPIOF_INIT flag should be used when using
devm_gpio_request_one().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/backlight/lms283gf05.c

index 13e24d52887ce57a53e75a017cc950a10591dd88..55819b3847014c56dab005851de06dc070f71042 100644 (file)
@@ -159,7 +159,8 @@ static int lms283gf05_probe(struct spi_device *spi)
 
        if (pdata != NULL) {
                ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
-                               GPIOF_DIR_OUT | !pdata->reset_inverted,
+                               GPIOF_DIR_OUT | (!pdata->reset_inverted ?
+                               GPIOF_INIT_HIGH : GPIOF_INIT_LOW),
                                "LMS285GF05 RESET");
                if (ret)
                        return ret;