]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
aoe: err device: include MAC addresses for unexpected responses
authorEd Cashin <ecashin@coraid.com>
Tue, 18 Dec 2012 00:03:45 +0000 (16:03 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 18 Dec 2012 01:15:24 +0000 (17:15 -0800)
The /dev/etherd/err character device provides low-level information about
normal but sometimes interesting AoE command retransmits and "unexpected
responses", i.e., responses for packets that have already been
retransmitted.

This change adds MAC addresses to the messages about unexpected responses,
so that when they occur, it's more easy to determine the network paths to
which they belong.

Signed-off-by: Ed Cashin <ecashin@coraid.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/block/aoe/aoecmd.c

index f849fa2471caf5e65310a72f6824018bdec52380..6ea27fd8954df833b781c1fe639a3683b7e38c74 100644 (file)
@@ -1204,12 +1204,14 @@ aoecmd_ata_rsp(struct sk_buff *skb)
                        spin_unlock_irqrestore(&d->lock, flags);
                        aoedev_put(d);
                        snprintf(ebuf, sizeof(ebuf),
-                                "%15s e%d.%d    tag=%08x@%08lx\n",
+                                "%15s e%d.%d    tag=%08x@%08lx s=%pm d=%pm\n",
                                 "unexpected rsp",
                                 get_unaligned_be16(&h->major),
                                 h->minor,
                                 get_unaligned_be32(&h->tag),
-                                jiffies);
+                                jiffies,
+                                h->src,
+                                h->dst);
                        aoechr_error(ebuf);
                        return skb;
                }