]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
sys_swapon: simplify error return from swap_info allocation
authorCesar Eduardo Barros <cesarb@cesarb.net>
Tue, 22 Mar 2011 23:33:18 +0000 (16:33 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 23 Mar 2011 00:44:06 +0000 (17:44 -0700)
At this point in sys_swapon, there is nothing to free. Return directly
instead of jumping to the cleanup block at the end of the function.

Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Tested-by: Eric B Munson <emunson@mgebm.net>
Acked-by: Eric B Munson <emunson@mgebm.net>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/swapfile.c

index 6d1c3c67ae65d5ddf37647fdc36ab91a1762f570..4d457d699c1f2c24e396e414ad714b085f149b87 100644 (file)
@@ -1918,10 +1918,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
                return -EPERM;
 
        p = alloc_swap_info();
-       if (IS_ERR(p)) {
-               error = PTR_ERR(p);
-               goto out;
-       }
+       if (IS_ERR(p))
+               return PTR_ERR(p);
 
        name = getname(specialfile);
        error = PTR_ERR(name);