fix bug in final check
authorJohn Stultz <>
Tue, 10 Jan 2012 23:41:15 +0000 (15:41 -0800)
committerMichal Marek <>
Sat, 14 Jan 2012 20:44:29 +0000 (21:44 +0100)
Arnaud Lacombe pointed out the final checking that the requested configs
were included in the final .config was broken.

The example was that if you had a fragment that disabled
CONFIG_DECOMPRESS_GZIP applied to a normal defconfig, there would be no
final warning that CONFIG_DECOMPRESS_GZIP was acutally set in the final

This bug was introduced by me in v3 of the original patch, and the
following patch reverts the invalid change.

Signed-off-by: John Stultz <>
Reported-by: Arnaud Lacombe <>
Cc: Darren Hart <>
Cc: Michal Marek <>
Cc: Arnaud Lacombe <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Michal Marek <>

index 07bb8863577b281e6eee6e237248acc8a6f68140..ceadf0e150cfe6cf4bc3d087b79b52df70f45a2e 100644 (file)
 # Check all specified config values took (might have missed-dependency issues)
 for CFG in $(sed -n "$SED_CONFIG_EXP" $TMP_FILE); do
-       REQUESTED_VAL=$(sed -n "$SED_CONFIG_EXP" $TMP_FILE | grep -w -e "$CFG")
-       ACTUAL_VAL=$(sed -n "$SED_CONFIG_EXP" .config | grep -w -e "$CFG")
+       REQUESTED_VAL=$(grep -w -e "$CFG" $TMP_FILE)
+       ACTUAL_VAL=$(grep -w -e "$CFG" .config)
        if [ "x$REQUESTED_VAL" != "x$ACTUAL_VAL" ] ; then
                echo "Value requested for $CFG not in final .config"
                echo "Requested value:  $REQUESTED_VAL"