]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
checkpatch: warn on unnecessary line continuations
authorJoe Perches <joe@perches.com>
Tue, 18 Dec 2012 00:01:47 +0000 (16:01 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 18 Dec 2012 01:15:18 +0000 (17:15 -0800)
When the previous line is not a line continuation and the current line has
a line continuation but is not a #define, emit a warning.

Signed-off-by: Joe Perches <joe@perches.com>
Cc: Peter Hurley <peter@hurleysoftware.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl

index f18750e3bd6c290b285464b193d7d65972b6de19..d4f61a6fed5db245630ac6c8f0f453a4ef381d6a 100755 (executable)
@@ -3013,6 +3013,15 @@ sub process {
                                              "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
                                }
                        }
+
+# check for line continuations outside of #defines
+
+               } else {
+                       if ($prevline !~ /^..*\\$/ &&
+                           $line =~ /^\+.*\\$/) {
+                               WARN("LINE_CONTINUATIONS",
+                                    "Avoid unnecessary line continuations\n" . $herecurr);
+                       }
                }
 
 # do {} while (0) macro tests: