]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
mmc: sdhci: add quirk for lack of 1.8v support
authorDaniel Drake <dsd@laptop.org>
Sun, 25 Nov 2012 18:01:19 +0000 (13:01 -0500)
committerChris Ball <cjb@laptop.org>
Thu, 6 Dec 2012 18:55:04 +0000 (13:55 -0500)
The OLPC XO-1.75 laptop includes a SDHCI controller which is 1.8v
capable, and it truthfully reports so in its capabilities. This
alternate voltage is used for driving new "UHS-I" SD cards at their
full speed.

However, what the controller doesn't know is that the motherboard
physically doesn't have a 1.8v supply available.

Add a quirk so that systems such as this one can override disable
1.8v support, adding support for UHS-I cards (by running them at
3.3v).

This avoids a problem where the system would first try to run the
card at 1.8v, fail, and then not be able to fully reset the card
to retry at the normal 3.3v voltage.

This is more appropriate than using the MISSING_CAPS quirk, which
is intended for cases where the SDHCI controller is actually lying
about its capabilities, and would force us to somehow override both
caps words from another source.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Reviewed-by: Philip Rakity <prakity@nvidia.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sdhci.c
include/linux/mmc/sdhci.h

index ec3e984129dca38d02c6a2bb20ad8b3e2400c683..f78c5b1329eb51ff8ce1616d58c40f4ae928adfb 100644 (file)
@@ -2867,6 +2867,10 @@ int sdhci_add_host(struct sdhci_host *host)
                                        SDHCI_SUPPORT_DDR50);
        }
 
                                        SDHCI_SUPPORT_DDR50);
        }
 
+       if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V)
+               caps[1] &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
+                      SDHCI_SUPPORT_DDR50);
+
        /* Any UHS-I mode in caps implies SDR12 and SDR25 support. */
        if (caps[1] & (SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
                       SDHCI_SUPPORT_DDR50))
        /* Any UHS-I mode in caps implies SDR12 and SDR25 support. */
        if (caps[1] & (SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
                       SDHCI_SUPPORT_DDR50))
index b34f3eb95f64240482d20466df138505ad361c49..4bbc3301fbbfef64988495a910f274825fccc057 100644 (file)
@@ -92,6 +92,8 @@ struct sdhci_host {
 
 #define SDHCI_QUIRK2_HOST_OFF_CARD_ON                  (1<<0)
 #define SDHCI_QUIRK2_HOST_NO_CMD23                     (1<<1)
 
 #define SDHCI_QUIRK2_HOST_OFF_CARD_ON                  (1<<0)
 #define SDHCI_QUIRK2_HOST_NO_CMD23                     (1<<1)
+/* The system physically doesn't support 1.8v, even if the host does */
+#define SDHCI_QUIRK2_NO_1_8_V                          (1<<2)
 
        int irq;                /* Device IRQ */
        void __iomem *ioaddr;   /* Mapped address */
 
        int irq;                /* Device IRQ */
        void __iomem *ioaddr;   /* Mapped address */