]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
hwmon: (lm90) Add range check to set_update_interval
authorGuenter Roeck <linux@roeck-us.net>
Mon, 16 Jan 2012 21:51:47 +0000 (22:51 +0100)
committerJean Delvare <khali@endymion.delvare>
Mon, 16 Jan 2012 21:51:47 +0000 (22:51 +0100)
When writing the update_interval attribute, the parameter value was
not range checked, which could cause an integer overflow and result
in an arbitrary update interval. Fix by limiting the value range to
<0, 100000>.

Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/lm90.c

index bdfd675488aeb5e64b9d4c144c5cfd185ad0ecb0..d2dd5f90496df1ca4393467e31f1ab78264f17d8 100644 (file)
@@ -917,7 +917,7 @@ static ssize_t set_update_interval(struct device *dev,
                return err;
 
        mutex_lock(&data->update_lock);
                return err;
 
        mutex_lock(&data->update_lock);
-       lm90_set_convrate(client, data, val);
+       lm90_set_convrate(client, data, SENSORS_LIMIT(val, 0, 100000));
        mutex_unlock(&data->update_lock);
 
        return count;
        mutex_unlock(&data->update_lock);
 
        return count;