dlm: don't use idr_remove_all()
authorTejun Heo <tj@kernel.org>
Thu, 28 Feb 2013 01:03:45 +0000 (17:03 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Feb 2013 03:10:13 +0000 (19:10 -0800)
idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated.

The conversion isn't completely trivial for recover_idr_clear() as it's
the only place in kernel which makes legitimate use of idr_remove_all()
w/o idr_destroy().  Replace it with idr_remove() call inside
idr_for_each_entry() loop.  It goes on top so that it matches the
operation order in recover_idr_del().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christine Caulfield <ccaulfie@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/dlm/lockspace.c
fs/dlm/recover.c

index 2e99fb0c973776fe9f103f5f0d220d2e7aceb256..3ca79d3253b9b195e698084f76cc23e686b5a0a7 100644 (file)
@@ -796,7 +796,6 @@ static int release_lockspace(struct dlm_ls *ls, int force)
         */
 
        idr_for_each(&ls->ls_lkbidr, lkb_idr_free, ls);
         */
 
        idr_for_each(&ls->ls_lkbidr, lkb_idr_free, ls);
-       idr_remove_all(&ls->ls_lkbidr);
        idr_destroy(&ls->ls_lkbidr);
 
        /*
        idr_destroy(&ls->ls_lkbidr);
 
        /*
index b2856e70164192837d06067e7417ac9a591235fb..236d1085d6a2eddadd756cae3c8dc1ad29df26eb 100644 (file)
@@ -359,13 +359,13 @@ static void recover_idr_clear(struct dlm_ls *ls)
        spin_lock(&ls->ls_recover_idr_lock);
 
        idr_for_each_entry(&ls->ls_recover_idr, r, id) {
        spin_lock(&ls->ls_recover_idr_lock);
 
        idr_for_each_entry(&ls->ls_recover_idr, r, id) {
+               idr_remove(&ls->ls_recover_idr, id);
                r->res_id = 0;
                r->res_recover_locks_count = 0;
                ls->ls_recover_list_count--;
 
                dlm_put_rsb(r);
        }
                r->res_id = 0;
                r->res_recover_locks_count = 0;
                ls->ls_recover_list_count--;
 
                dlm_put_rsb(r);
        }
-       idr_remove_all(&ls->ls_recover_idr);
 
        if (ls->ls_recover_list_count != 0) {
                log_error(ls, "warning: recover_list_count %d",
 
        if (ls->ls_recover_list_count != 0) {
                log_error(ls, "warning: recover_list_count %d",