mm: reduce rmap overhead for ex-KSM page copies created on swap faults
authorJohannes Weiner <>
Sat, 23 Feb 2013 00:32:20 +0000 (16:32 -0800)
committerLinus Torvalds <>
Sun, 24 Feb 2013 01:50:09 +0000 (17:50 -0800)
When ex-KSM pages are faulted from swap cache, the fault handler is not
capable of re-establishing anon_vma-spanning KSM pages.  In this case, a
copy of the page is created instead, just like during a COW break.

These freshly made copies are known to be exclusive to the faulting VMA
and there is no reason to go look for this page in parent and sibling
processes during rmap operations.

Use page_add_new_anon_rmap() for these copies.  This also puts them on
the proper LRU lists and marks them SwapBacked, so we can get rid of
doing this ad-hoc in the KSM copy code.

Signed-off-by: Johannes Weiner <>
Reviewed-by: Rik van Riel <>
Acked-by: Hugh Dickins <>
Cc: Simon Jeons <>
Cc: Mel Gorman <>
Cc: Michal Hocko <>
Cc: Satoru Moriya <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>

index 51573858938d1435a5b74c2c36dbd833b5c27837..e1f1f278075fc63fdde1b808c118c6dee2e88a64 100644 (file)
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -1590,13 +1590,7 @@ struct page *ksm_does_need_to_copy(struct page *page,
-               SetPageSwapBacked(new_page);
-               if (!mlocked_vma_newpage(vma, new_page))
-                       lru_cache_add_lru(new_page, LRU_ACTIVE_ANON);
-               else
-                       add_page_to_unevictable_list(new_page);
        return new_page;
index bb1369f7b9b4ba8af51d90a40de8f522aa2470dc..0abd07097ec6cdfa602fbbf4e9b2e1b186ec3723 100644 (file)
@@ -3044,7 +3044,10 @@ static int do_swap_page(struct mm_struct *mm, struct vm_area_struct *vma,
        flush_icache_page(vma, page);
        set_pte_at(mm, address, page_table, pte);
-       do_page_add_anon_rmap(page, vma, address, exclusive);
+       if (swapcache) /* ksm created a completely new copy */
+               page_add_new_anon_rmap(page, vma, address);
+       else
+               do_page_add_anon_rmap(page, vma, address, exclusive);
        /* It's better to call commit-charge after rmap is established */
        mem_cgroup_commit_charge_swapin(page, ptr);