]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
USB: gadget: Remove suspended sysfs file before freeing cdev
authorPavankumar Kondeti <pkondeti@codeaurora.org>
Thu, 16 Dec 2010 09:02:25 +0000 (14:32 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 16 Dec 2010 23:45:44 +0000 (15:45 -0800)
cdev struct is accessed in suspended sysfs show function.  So
remove sysfs file before freeing the cdev in composite_unbind.

Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/gadget/composite.c

index 7b5cc16e4a0bbc4b61e0627df7bee1479fbda2f4..96413a240fdfa786a3e18a2db5ff0d99e37fb4fb 100644 (file)
@@ -1047,9 +1047,9 @@ composite_unbind(struct usb_gadget *gadget)
                kfree(cdev->req->buf);
                usb_ep_free_request(gadget->ep0, cdev->req);
        }
+       device_remove_file(&gadget->dev, &dev_attr_suspended);
        kfree(cdev);
        set_gadget_data(gadget, NULL);
-       device_remove_file(&gadget->dev, &dev_attr_suspended);
        composite = NULL;
 }