]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
sparc: fix build
authorDavid Rientjes <rientjes@google.com>
Sat, 23 Feb 2008 23:23:34 +0000 (15:23 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 24 Feb 2008 01:12:14 +0000 (17:12 -0800)
Fix build failure on sparc:

In file included from include/linux/mm.h:39,
                from include/linux/memcontrol.h:24,
                from include/linux/swap.h:8,
                from include/linux/suspend.h:7,
                from init/do_mounts.c:6:
include/asm/pgtable.h:344: warning: parameter names (without
types) in function declaration
include/asm/pgtable.h:345: warning: parameter names (without
types) in function declaration
include/asm/pgtable.h:346: error: expected '=', ',', ';', 'asm' or
'__attribute__' before '___f___swp_entry'

viro sayeth:

  I've run allmodconfig builds on a bunch of target, FWIW (essentially the
  same patch).  Note that these includes are recent addition caused by added
  inline function that had since then become a define.  So while I agree with
  your comments in general, in _this_ case it's pretty safe.

  The commit that had done it is 3062fc67dad01b1d2a15d58c709eff946389eca4
  ("memcontrol: move mm_cgroup to header file") and the switch to #define
  is in commit 60c12b1202a60eabb1c61317e5d2678fcea9893f ("memcontrol: add
  vm_match_cgroup()") (BTW, that probably warranted mentioning in the
  changelog of the latter).

Cc: Adrian Bunk <bunk@kernel.org>
Cc: Robert Reif <reif@earthlink.net>
Signed-off-by: David Rientjes <rientjes@google.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

index 925d57b236aad811344b7b6a787c31c32c45eb2b..04075628cb9a315d31acc90bf2bc165606d80e15 100644 (file)
@@ -20,9 +20,6 @@
-#include <linux/rcupdate.h>
-#include <linux/mm.h>
 struct mem_cgroup;
 struct page_cgroup;
 struct page;