perf top: Add missing newline on pr_err call
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 21 Nov 2012 21:58:50 +0000 (18:58 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sun, 9 Dec 2012 11:46:05 +0000 (08:46 -0300)
The perf_event__process_sample function, when not finding a machine
associated with a sample, was calling pr_err without a newline,
garbling the screen on TUI mode due to a problem introduced by a
recent ui_helpline patch.

On --stdio it would just concatenate the messages for each sample with
no machine associated, fix it by adding the newline.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-vuz88welqvp15c2uybd9osnz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c

index c9ff395..987e1b8 100644 (file)
@@ -727,7 +727,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
        }
 
        if (!machine) {
        }
 
        if (!machine) {
-               pr_err("%u unprocessable samples recorded.",
+               pr_err("%u unprocessable samples recorded.\n",
                       top->session->hists.stats.nr_unprocessable_samples++);
                return;
        }
                       top->session->hists.stats.nr_unprocessable_samples++);
                return;
        }